Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop custom (v)snprintf definition #992

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix: drop custom (v)snprintf definition #992

merged 1 commit into from
Dec 20, 2023

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Dec 20, 2023

The functions are available since C++11.

The functions are available since C++11.
@sergiud sergiud added this to the 0.7 milestone Dec 20, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7d973f9) 63.92% compared to head (1bb2eec) 64.25%.

Files Patch % Lines
src/utilities.cc 25.00% 3 Missing ⚠️
src/logging.cc 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
+ Coverage   63.92%   64.25%   +0.33%     
==========================================
  Files          17       17              
  Lines        3326     3321       -5     
  Branches     1125     1124       -1     
==========================================
+ Hits         2126     2134       +8     
+ Misses        774      762      -12     
+ Partials      426      425       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiud sergiud merged commit 3fcf77a into master Dec 20, 2023
268 checks passed
@sergiud sergiud deleted the drop-snprintf branch December 20, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants