Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google.golang.org/genproto #393

Merged
merged 1 commit into from
May 26, 2023
Merged

Bump google.golang.org/genproto #393

merged 1 commit into from
May 26, 2023

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented May 26, 2023

This picks up a version of genproto that separates api and rpc packages into submodules, to enable dropping transitive dependencies on cloud API packages in the future for uses of those generic packages.

See googleapis/go-genproto#1015 for details on the timeline for completing the submodule isolation.

cc @apelisse @Jefftree

@liggitt liggitt requested a review from a team as a code owner May 26, 2023 17:35
@apelisse
Copy link

Thanks Tim for looking at it!

@timburks
Copy link
Contributor

Hi @liggitt, thanks for this update! Could you merge the latest from main into this branch? I've updated the CI action so that the tests should now run.

This picks up a version of genproto that separates api and rpc packages into submodules,
to enable dropping transitive dependencies on cloud API packages in the future
for uses of those generic packages.
@liggitt
Copy link
Contributor Author

liggitt commented May 26, 2023

sure, rebased

@timburks timburks merged commit a5c9e9c into google:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants