samples: move go.mod into samples root, making samples its own module #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2057 +/- ##
======================================
Coverage 76.8% 76.8%
======================================
Files 82 82
Lines 9868 9868
======================================
Hits 7579 7579
Misses 1729 1729
Partials 560 560
Continue to review full report at Codecov.
|
vangent
approved these changes
May 13, 2019
vangent
changed the title
This was referenced May 13, 2019
eliben
added a commit
that referenced
this pull request
May 14, 2019
|
Can you also update the VSCode workspace? Otherwise IntelliSense breaks. |
|
@zombiezen, sure thing #2076 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #2048 - moves the go.mod file from samples/appengine to samples.
Note the
replace gocloud.dev => ../added to the go.mod. Without this, runninggo test ./...insamples/results in many errors like:The symptom and solution is explained by bcmills in ugorji/go#279 (which refers also to golang/go#27899). The new go.mod points to gocloud.dev v0.13, which also provides these packages - so the go command is confused - it sees the same package(s) provided by two different modules.
The ugorji/go solution was to use a pseudo-version pointing at an existing commit in the core module which removes the packages - this removes the ambiguity. In our case, there is no existing commit yet - so I'm using a replace line. The replace line should be unnecessary when we release a new CDK version.
This has interesting implications for #886 - we'll likely have to do the same when we split out providers to their own modules and retain
replacelines until a new release.