Improve test coverage

google · Dec 16, 2020 · dcf13b4 · dcf13b4
1 parent 6f042a1
commit dcf13b4
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/pkg/v1/v1util/zip_test.go b/pkg/v1/v1util/zip_test.go
@@ -139,21 +139,30 @@ func (f failReader) Read(_ []byte) (int, error) {
 func TestReadErrors(t *testing.T) {
 	fr := failReader{}
 	if _, err := IsGzipped(fr); err != errRead {
-		t.Errorf("IsGzipped: expected errRead, got %v", err)
+		t.Error("IsGzipped: expected errRead, got", err)
 	}
 
 	frc := ioutil.NopCloser(fr)
 	if _, err := GunzipReadCloser(frc); err != errRead {
-		t.Errorf("GunzipReadCloser: expected errRead, got %v", err)
+		t.Error("GunzipReadCloser: expected errRead, got", err)
 	}
 
 	zr := GzipReadCloser(ioutil.NopCloser(fr))
 	if _, err := zr.Read(nil); err != errRead {
-		t.Errorf("GzipReadCloser: expected errRead, got %v", err)
+		t.Error("GzipReadCloser: expected errRead, got", err)
 	}
 
 	zr = GzipReadCloserLevel(ioutil.NopCloser(strings.NewReader("zip me")), -10)
 	if _, err := zr.Read(nil); err == nil {
-		t.Errorf("Expected invalid level error, got: %v", err)
+		t.Error("Expected invalid level error, got:", err)
+	}
+
+	if _, _, err := EstargzReadCloser(ioutil.NopCloser(fr)); err != errRead {
+		t.Error("EstargzReadCloser: expected errRead, got", err)
+	}
+
+	buf := bytes.NewBufferString("not a tarball")
+	if _, _, err := EstargzReadCloser(ioutil.NopCloser(buf)); !strings.Contains(err.Error(), "failed to parse tar file") {
+		t.Error(`EstargzReadCloser: expected "failed to parse tar file", got`, err)
 	}
 }