Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define minimum golang version #27

Closed
dekkagaijin opened this issue Mar 18, 2018 · 3 comments
Closed

Define minimum golang version #27

dekkagaijin opened this issue Mar 18, 2018 · 3 comments

Comments

@dekkagaijin
Copy link
Contributor

Add validation to travis:

go:
  - ${MINIMUM_VERSION}
  - tip
@jonjohnsonjr
Copy link
Collaborator

How does one determine the minimum golang version?

@dekkagaijin
Copy link
Contributor Author

Whatever the minimum version for the set of features you want to use is. Honestly picking something arbitrary for now is fine, like "1.10" (you have to add quotes, or travis parses it as 1.1)

jonjohnsonjr added a commit to jonjohnsonjr/go-containerregistry that referenced this issue Jun 5, 2018
@jonjohnsonjr
Define minimum golang version
eebcdcb 
Fixes google#27.
@jonjohnsonjr
Copy link
Collaborator

(you have to add quotes, or travis parses it as 1.1)

Lovely!

@jonjohnsonjr jonjohnsonjr mentioned this issue Jun 5, 2018
Merged
jonjohnsonjr added a commit to jonjohnsonjr/go-containerregistry that referenced this issue Jun 5, 2018
@jonjohnsonjr
Define minimum golang version
ab27334 
Fixes google#27.
dekkagaijin pushed a commit that referenced this issue Jun 5, 2018
@jonjohnsonjr @dekkagaijin
Define minimum golang version (#204)
dc0a777 
Fixes #27.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dekkagaijin @jonjohnsonjr