Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Azure Container Registry authentication #1256

Closed
wants to merge 2 commits into from
Closed

Fix Azure Container Registry authentication #1256

wants to merge 2 commits into from

Commits on Jan 24, 2022

  1. Add support for IdentityToken in NewKeychainFromHelper() 

    This will return an IdentityToken instead of a password if the username
is set to '<token>'.

This is based on the documentation from Docker as well as the code in
go-containerregistry that only will use OAuth if there's an
IdentityToken present.

Reference to the documentation:
https://docs.docker.com/engine/reference/commandline/login/#credential-helper-protocol
    @simongottschlag
    simongottschlag committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    2b443e7 View commit details
    Browse the repository at this point in the history

  2. Make NewKeychainFromHelper() use r.RegistryStr() instead of r.String() 

    This will ensure helpers don't need to strip path and query or validate
if the scheme is present in the string or not.
    @simongottschlag
    simongottschlag committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    94987f2 View commit details
    Browse the repository at this point in the history