-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add support for new Referrers API #1455
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1455 +/- ##
==========================================
- Coverage 73.31% 71.98% -1.33%
==========================================
Files 115 118 +3
Lines 8772 9064 +292
==========================================
+ Hits 6431 6525 +94
- Misses 1696 1861 +165
- Partials 645 678 +33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This Pull Request is stale because it has been open for 90 days with |
Supercedes #1425 since I just wasn't feeling that PR, and I think enough changed in the acceptance of the spec changes that I wanted to start over.
API-wise I think this is pretty good, both in terms of
remote.Referrers(name.Digest)
andimg.Referrers()
and the CLI surfacecrane attach <ref>
andcrane referrers <ref> -f foo.txt -t sbom
.Everything should support fetching referrers for a manifest-by-digest that doesn't exist, and updating the manifest(-that-might-not-exist) when a manifest specifies a
subject
, going through the fallback tag flow and updating the index manifest, while deduping and sorting.As with #1425 it needs tests, which will need pkg/registry support. A
Walk
method would be nice. Support forArtifactManifest
is commented out but mostly would be easy to add.cc @jdolitsky
Progress toward #1434