Skip to content

Commit

Permalink
Apply review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
denist11 committed Apr 9, 2023
1 parent 706a6db commit bc30782
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 13 deletions.
8 changes: 4 additions & 4 deletions github/github-accessors.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions github/github-accessors_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions github/repos_pages.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ type PagesBuild struct {
UpdatedAt *Timestamp `json:"updated_at,omitempty"`
}

// PagesDomain represents a domain associated with a Github Pages site.
// PagesDomain represents a domain associated with a GitHub Pages site.
type PagesDomain struct {
Host *string `json:"host,omitempty"`
URI *string `json:"uri,omitempty"`
Expand All @@ -58,7 +58,7 @@ type PagesDomain struct {
IsFastlyIP *bool `json:"is_fastly_ip,omitempty"`
IsOldIPAddress *bool `json:"is_old_ip_address,omitempty"`
IsARecord *bool `json:"is_a_record,omitempty"`
HasCNAMERecordPresent *bool `json:"has_cname_record,omitempty"`
HasCNAMERecord *bool `json:"has_cname_record,omitempty"`
HasMXRecordsPresent *bool `json:"has_mx_records_present,omitempty"`
IsValidDomain *bool `json:"is_valid_domain,omitempty"`
IsApexDomain *bool `json:"is_apex_domain,omitempty"`
Expand All @@ -79,7 +79,7 @@ type PagesDomain struct {
CAAError *string `json:"caa_error,omitempty"`
}

// PagesHealthCheckResponse represents the response given for the health check of a Github Pages site.
// PagesHealthCheckResponse represents the response given for the health check of a GitHub Pages site.
type PagesHealthCheckResponse struct {
Domain *PagesDomain `json:"domain,omitempty"`
AltDomain *PagesDomain `json:"alt_domain,omitempty"`
Expand Down
2 changes: 1 addition & 1 deletion github/repos_pages_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ func TestPagesHealthCheckResponse_Marshal(t *testing.T) {
IsFastlyIP: Bool(false),
IsOldIPAddress: Bool(false),
IsARecord: Bool(true),
HasCNAMERecordPresent: Bool(false),
HasCNAMERecord: Bool(false),
HasMXRecordsPresent: Bool(false),
IsValidDomain: Bool(true),
IsApexDomain: Bool(true),
Expand Down

0 comments on commit bc30782

Please sign in to comment.