Turn RequiredStatusChecks Checks and Contexts into pointers (#3070

) Fixes: #2976 and #2467.
google · Feb 11, 2024 · dd4d2a1 · dd4d2a1
1 parent 5145e7f
commit dd4d2a1
Show file tree

Hide file tree

Showing 5 changed files with 384 additions and 27 deletions.
diff --git a/github/github-accessors.go b/github/github-accessors.go
diff --git a/github/github-accessors_test.go b/github/github-accessors_test.go
diff --git a/github/repos.go b/github/repos.go
@@ -1191,20 +1191,20 @@ type RequiredStatusChecks struct {
 	// Require branches to be up to date before merging. (Required.)
 	Strict bool `json:"strict"`
 	// The list of status checks to require in order to merge into this
-	// branch. (Deprecated. Note: only one of Contexts/Checks can be populated,
-	// but at least one must be populated).
-	Contexts []string `json:"contexts,omitempty"`
+	// branch. An empty slice is valid. (Deprecated. Note: only one of
+	// Contexts/Checks can be populated, but at least one must be populated).
+	Contexts *[]string `json:"contexts,omitempty"`
 	// The list of status checks to require in order to merge into this
-	// branch.
-	Checks      []*RequiredStatusCheck `json:"checks,omitempty"`
-	ContextsURL *string                `json:"contexts_url,omitempty"`
-	URL         *string                `json:"url,omitempty"`
+	// branch. An empty slice is valid.
+	Checks      *[]*RequiredStatusCheck `json:"checks,omitempty"`
+	ContextsURL *string                 `json:"contexts_url,omitempty"`
+	URL         *string                 `json:"url,omitempty"`
 }
 
 // RequiredStatusChecksRequest represents a request to edit a protected branch's status checks.
 type RequiredStatusChecksRequest struct {
 	Strict *bool `json:"strict,omitempty"`
-	// Note: if both Contexts and Checks are populated,
+	// Deprecated. Note: if both Contexts and Checks are populated,
 	// the GitHub API will only use Checks.
 	Contexts []string               `json:"contexts,omitempty"`
 	Checks   []*RequiredStatusCheck `json:"checks,omitempty"`