Skip to content

Commit

Permalink
Update workflow and tools to use Go 1.23 and 1.22 (#3242)
Browse files Browse the repository at this point in the history
  • Loading branch information
gmlewis authored Aug 21, 2024
1 parent 280d327 commit de03f7b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
shell: bash
strategy:
matrix:
go-version: [1.x, 1.21.x]
go-version: [1.x, 1.22.x]
platform: [ubuntu-latest]
include:
# include windows, but only with the latest Go version, since there
Expand Down
6 changes: 4 additions & 2 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ linters-settings:
# performance issue: see https://github.com/golangci/golangci-lint/issues/4039
# and https://github.com/securego/gosec/issues/1007
- G602
# int(os.Stdin.Fd())
- G115
issues:
exclude-use-default: false
exclude-rules:
Expand All @@ -43,9 +45,9 @@ issues:
text: 'G505: Blocklisted import crypto/sha1: weak cryptographic primitive'

# This is adapted from golangci-lint's default exclusions. It disables linting for error checks on
# os.RemoveAll and any function ending in "Close".
# os.RemoveAll, fmt.Fprint*, fmt.Scanf, and any function ending in "Close".
- linters: [ errcheck ]
text: Error return value of .(.*Close|os\.Remove(All)?). is not checked
text: Error return value of .(.*Close|fmt\.Fprint.*|fmt\.Scanf|os\.Remove(All)?). is not checked

# We don't care about file inclusion via variable in examples or internal tools.
- linters: [ gosec ]
Expand Down
2 changes: 1 addition & 1 deletion script/lint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

set -e

GOLANGCI_LINT_VERSION="1.54.2"
GOLANGCI_LINT_VERSION="1.60.2"

CDPATH="" cd -- "$(dirname -- "$0")/.."
BIN="$(pwd -P)"/bin
Expand Down

0 comments on commit de03f7b

Please sign in to comment.