Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields to get branch protection API to match GitHub APIs #2719

Closed
annadorottya opened this issue Mar 27, 2023 · 1 comment · Fixed by #2744
Closed

Add fields to get branch protection API to match GitHub APIs #2719

annadorottya opened this issue Mar 27, 2023 · 1 comment · Fixed by #2744

Comments

@annadorottya
Copy link

Upon comparing the API response of the get branch protection endpoint and the struct implemented here I noticed a few fields missing:

  • required_pull_request_reviews.url string
  • required_signatures.enabled boolean
  • required_signature.url string
  • required_status_checks.contexts []string
  • required_status_checks.contexts_url string
  • required_status_checks.url string
  • url string

Not sure if the url types of fields are left out on purpose but there are some cases when they are implemented (eg. enforce_admins.url) so I included them.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 27, 2023

Thank you, @annadorottya . Will you be providing a PR, or do you want me to open up this issue to other contributors to this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants