Failure unmarshalling organization with large PrivateRepos number in plan

[shaines1]

Hello,

I am attempting to use the integrations/github Terraform provider with GitHub Enterprise Server. Executing terraform plan and terraform apply with infrastructure definitions that require interacting with organizations hosted in the GHES instance result in the following go-github error:

│ Error: json: cannot unmarshal number 999999999999 into Go struct field Plan.plan.private_repos of type int
│
│   with data.github_organization.architecture,
│   on main.tf line 14, in data "github_organization" "myorg":
│   14: data "github_organization" "myorg" {

On inspection of the organization JSON representation, the plan.private_repos has a value of 999999999999. My assumption is that the unmarshalling error is due to the PrivateRepos variable in go-github only being declared as an int.

Here's an abbreviated snippet of the organization JSON output:

{
  "login": "myorg",
  "id": 1,
  "plan": {
    "name": "enterprise",
    "space": 1,
    "private_repos": 999999999999,
    "filled_seats": 1,
    "seats": 0
  }
}

Would it be possible to modify this data type? Please let me know if there's anything else that would be helpful to provide!

Environment

• GitHub Enterprise Server: 3.8.0
• Terraform: 1.4.2
• integrations/github: 5.20
• go-github: v50.2.0

[gmlewis]

Something seems fishy here... have you looked at the JSON output directly from the server (using curl for example)?
Is it really sending that number?!? Doesn't that seem like a GitHub problem? Have you contacted GitHub tech support?

[shaines1]

Something seems fishy here...

I agree

have you looked at the JSON output directly from the server (using curl for example)? Is it really sending that number?!?

Yes. Using an PAT as an org owner to https://<base_url>/api/v3/orgs/<org_name> with Postman returns the same result. It doesn't appear to be a permission issue, as the remainder of the response looks correct

Doesn't that seem like a GitHub problem? Have you contacted GitHub tech support?

Yes, my colleague has. I'll update here with their response when we receive it

[MISO-mgriffin]

Received confirmation from GitHub that this is the expected value when using GitHub Enterprise Server. This library will need to be updated to accommodate the larger value.

The GitHub Enterprise Server plan, by design, returns 999999999999. GitHub Enterprise Cloud returns 999999 however. As 999999999999 is larger than a 32-bit int, you'll need to be able to handle this in your code/that of libraries you use.

[gmlewis]

@MISO-mgriffin - thank you!
I'll put together a PR for a breaking change, one moment.

[gmlewis]

@shaines1 and/or @MISO-mgriffin - could you please review (and LGTM+Approve if you agree) with #2738 when you have a moment?