Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UploadSarif Always Returns An Error #3036

Closed
Rigdon opened this issue Jan 3, 2024 · 3 comments · Fixed by #3047
Closed

UploadSarif Always Returns An Error #3036

Rigdon opened this issue Jan 3, 2024 · 3 comments · Fixed by #3047
Assignees
@Rigdon

Comments

@Rigdon
Copy link
Contributor

Rigdon commented Jan 3, 2024 •
edited
Loading

In version 57.0.0 of go-github, UploadSarif never returns a valid SarifID object because it's propagating the AcceptedError instead of deserializing the body because this endpoint returns a 202. It seems to exhibit the same behavior that was fixed for CreateFork in #878.
@gmlewis
Copy link
Collaborator

gmlewis commented Jan 3, 2024

Thank you, @Rigdon . Would you like to submit a PR to fix this, or shall we open this up to other contributors?

@Rigdon
Copy link
Contributor Author

Rigdon commented Jan 3, 2024

I'll actually try to get a PR open this week.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 3, 2024

Thank you, @Rigdon !

@Rigdon Rigdon mentioned this issue Jan 10, 2024
Merged
gmlewis pushed a commit that referenced this issue Jan 10, 2024
@Rigdon
Fix issue in AcceptedError handling for UploadSarif (#3047)
207a38d 
Fixes: #3036.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rigdon Rigdon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue in AcceptedError handling for UploadSarif Rigdon/go-github
2 participants
@Rigdon @gmlewis