-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access token leakage when reusing the client between users #3043
Comments
Have you tried the latest version after #3011? |
So, I tried the new version, and the test still fails
|
Also, I've tested it on |
👍 So, I confirm that the test PASSED being runned on the branch https://github.com/gmlewis/go-github/tree/i3043-leaky-client-transport-copy Thank you! |
@gmlewis 👍 LGTM I know it's too late, but I just wanted to express my appreciation :) |
Description
Reusing the
github.Client
instance between different users' sessions leads to leaking the access_token between sessions.How to reproduce
This scenario works in a hosted service environment.
This test reproduces the issue
and the result
Used environment
The text was updated successfully, but these errors were encountered: