Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Topics to EditChange struct #3056

Closed
riaje opened this issue Jan 24, 2024 · 2 comments · Fixed by #3057
Closed

Add Topics to EditChange struct #3056

riaje opened this issue Jan 24, 2024 · 2 comments · Fixed by #3057

Comments

@riaje
Copy link
Contributor

riaje commented Jan 24, 2024

Hi,

I want to add the missing Topics field for the EditChange struct.

In my case, it will allow me to retrieve the previous topics when I receive the repository edited event.

I already have the branch ready for review.

Thanks

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 24, 2024

Sounds great, thanks, @riaje !
Our CONTRIBUTING.md guide has helpful information in it for submitting PRs if you are new to this repo.
Specifically, step 4 seems to be a commonly-missed step.

@riaje
Copy link
Contributor Author

riaje commented Jan 24, 2024

Already read 👍 thanks for the reminder of course !
The PR is submit, it's my first contribution to an open project on GitHub so I discover the process in the same time 😆
Thanks

gmlewis pushed a commit that referenced this issue Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants