Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Multi-select Custom Properties are not supported #3198

Closed
darend opened this issue Jul 5, 2024 · 7 comments · Fixed by #3200
Closed

Bug: Multi-select Custom Properties are not supported #3198

darend opened this issue Jul 5, 2024 · 7 comments · Fixed by #3200
Assignees
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). bug good first issue

Comments

@darend
Copy link

darend commented Jul 5, 2024

Issue

The Github API supports organizational custom properties with the following types: string, single_select, multi_select, true_false. Creating a property with type multi_select or true_false breaks many of the library interactions due to unmarshalling errors

API Reference: https://docs.github.com/en/rest/orgs/custom-properties?apiVersion=2022-11-28#create-or-update-custom-properties-for-an-organization

Reproducing

  • Create a custom property of type multi_select via the UI
  • Use library to get organizational custom properties
    • Unmarshalling error
  • Assign the custom property a value on a repository
  • Use the library to get the Repository
  • Unmarshalling error
@gmlewis
Copy link
Collaborator

gmlewis commented Jul 5, 2024

Thank you, @darend.
Would you like to create a PR, or shall I open this issue up to other contributors to this repo?

@darend
Copy link
Author

darend commented Jul 5, 2024

@gmlewis , you can open to the community

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 5, 2024

This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started. (In particular, please remember to go generate ./... and don't use force-push to your PRs.)

Thank you!

@arymoraes
Copy link
Contributor

This would be a great PR for any new contributor to this repo or a new Go developer. All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started. (In particular, please remember to go generate ./... and don't use force-push to your PRs.)

Thank you!

@gmlewis I am a new Go developer and would like to volunteer to work on this issue if possible. Thank you!

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 6, 2024

@gmlewis I am a new Go developer and would like to volunteer to work on this issue if possible. Thank you!

Thank you, @arymoraes! It's yours.

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 6, 2024

Welcome to Go, @arymoraes! It's one of my favorite languages and I'm sure you will enjoy the experience after you spend a bit of time with it.

@arymoraes
Copy link
Contributor

Welcome to Go, @arymoraes! It's one of my favorite languages and I'm sure you will enjoy the experience after you spend a bit of time with it.

Awesome, thank you. Looking forward for the experience!

@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jul 7, 2024
gmlewis pushed a commit that referenced this issue Jul 24, 2024
Fixes #3198.

BREAKING CHANGE: CustomPropertyValue.Value is changed from *string to interface{} to support string and []string values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). bug good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants