test cases for JSON marshalling

[vaibhavsingh97]

Related Issue: #55

[codecov]

Codecov Report

Merging #1144 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1144   +/-   ##
=======================================
  Coverage   70.18%   70.18%           
=======================================
  Files          84       84           
  Lines        5792     5792           
=======================================
  Hits         4065     4065           
  Misses        947      947           
  Partials      780      780

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c49e1...b45b1d2. Read the comment docs.

[vaibhavsingh97]

@gmlewis All test case passes, still travis failed 😞. Please let me know the possible fix

[gmlewis]

Without looking at the Travis CI logs, I can see that at least the first file has not been run through gofmt.

Please see CONTRIBUTING.md and follow the directions there. Thanks.

[vaibhavsingh97]

@gmlewis I already ran go fmt ./... on my patch before sending PR

[gmlewis]

Looking at the logs from Travis CI, it says:

$ diff -u <(echo -n) <(gofmt -d -s .)
--- /dev/fd/63	2019-04-02 22:46:57.657608030 +0000
+++ /dev/fd/62	2019-04-02 22:46:57.657608030 +0000
@@ -0,0 +1,12 @@
+diff -u github/gists_test.go.orig github/gists_test.go
+--- github/gists_test.go.orig	2019-04-02 22:46:57.721579604 +0000
++++ github/gists_test.go	2019-04-02 22:46:57.721579604 +0000
+@@ -43,7 +43,7 @@
+ 			URL:         String("u"),
+ 		},
+ 		Files: map[GistFilename]GistFile{
+-			"gistfile.py": GistFile{
++			"gistfile.py": {
+ 				Size:     Int(167),
+ 				Filename: String("gistfile.py"),
+ 				Language: String("Python"),
The command "diff -u <(echo -n) <(gofmt -d -s .)" exited with 1.

What version of go are you using?
After running go fmt ./..., did you remember to commit the changes before pushing to your PR?
What does git status say in your repo?

[vaibhavsingh97]

go version go1.11.5

I did commit the changes, before sending the PR. Should I retrigger travis, might be there was some issue?

[gmlewis]

No, there is no need, as it is obviously not formatted properly.
Click on the Files changed tab in GitHub and scroll down... you will see misalignments in many places.
Try pushing to the PR again with the correctly-formatted code.

[vaibhavsingh97]

Gotcha! Will update after proper formatting the code 👍

[gmlewis]

Thanks, @vaibhavsingh97!

LGTM.

Awaiting second LGTM before merging.

[gauntface]

thank you for the tests :)

[gmlewis]

Thank you, @gauntface!
Merging.