Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go module in test directory #1159

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Use go module in test directory #1159

merged 1 commit into from
Apr 19, 2019

Conversation

haya14busa
Copy link
Contributor

It removed github.com/google/go-github v17.0.0+incompatible dependencies
in go.mod.

@haya14busa
Use go module in test directory
6ac0e7d 
It removed github.com/google/go-github v17.0.0+incompatible dependencies
in go.mod.
@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Apr 19, 2019
@codecov
Copy link

codecov bot commented Apr 19, 2019 •
edited
Loading

Codecov Report

Merging #1159 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1159   +/-   ##
=======================================
  Coverage   70.17%   70.17%           
=======================================
  Files          84       84           
  Lines        5824     5824           
=======================================
  Hits         4087     4087           
  Misses        952      952           
  Partials      785      785

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df12fde...6ac0e7d. Read the comment docs.

gmlewis
gmlewis approved these changes Apr 19, 2019
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @haya14busa!
LGTM.
Merging.

@gmlewis gmlewis merged commit 3a61e2f into google:master Apr 19, 2019
@haya14busa haya14busa deleted the patch branch April 20, 2019 08:46
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@haya14busa @gmlewis
Use go module in test directory (google#1159)
a766bb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haya14busa @gmlewis @googlebot