Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for resource marshalling and unmarshalling #1189

Merged
merged 4 commits into from
Jun 11, 2019
Merged

Tests for resource marshalling and unmarshalling #1189

merged 4 commits into from
Jun 11, 2019

Conversation

fiskeben
Copy link
Contributor

Relates to #55

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jun 10, 2019
@codecov
Copy link

codecov bot commented Jun 10, 2019 •
edited
Loading

Codecov Report

Merging #1189 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1189      +/-   ##
=========================================
- Coverage   70.24%   70.2%   -0.04%     
=========================================
  Files          84      84              
  Lines        5878    5904      +26     
=========================================
+ Hits         4129    4145      +16     
- Misses        958     963       +5     
- Partials      791     796       +5
Impacted Files Coverage Δ
github/pulls.go 71.42% <0%> (-1.24%) ⬇️
github/repos_commits.go 70.73% <0%> (-1.1%) ⬇️
github/github.go 87.53% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a35880...0ba41c2. Read the comment docs.

gmlewis
gmlewis approved these changes Jun 10, 2019
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @fiskeben!
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from gauntface June 10, 2019 20:21
vaibhavsingh97
vaibhavsingh97 approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@vaibhavsingh97 vaibhavsingh97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks, @fiskeben for the PR ❤️

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 11, 2019

Thank you, @fiskeben and @vaibhavsingh97!

Merging.

@gmlewis gmlewis merged commit 8bcc047 into google:master Jun 11, 2019
@fiskeben fiskeben deleted the unit-tests branch June 11, 2019 13:54
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@fiskeben @gmlewis
Add tests for resource JSON marshaling and unmarshaling (google#1189)
f24be54 
Helps google#55.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaibhavsingh97 vaibhavsingh97 vaibhavsingh97 approved these changes

@gmlewis gmlewis gmlewis approved these changes

@gauntface gauntface Awaiting requested review from gauntface

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fiskeben @gmlewis @vaibhavsingh97 @googlebot