added test for JSON marshalling for Reaction and Reactions - relates to (#55) #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1324 +/- ##
=======================================
Coverage 73.45% 73.45%
=======================================
Files 86 86
Lines 6061 6061
=======================================
Hits 4452 4452
Misses 838 838
Partials 771 771Continue to review full report at Codecov.
|
gmlewis
requested changes
Oct 29, 2019
There was a problem hiding this comment.
Thank you, @thomaslanghorst!
Please make a couple minor tweaks and then we can merge.
github/reactions_test.go
Outdated
| @@ -12,6 +12,53 @@ import ( | |||
| "testing" | |||
| ) | |||
|
|
|||
| func TestReaction_marshall(t *testing.T) { | |||
There was a problem hiding this comment.
Let's please name this: TestReaction_Marshal (one 'el', capital 'M').
github/reactions_test.go
Outdated
| testJSONMarshal(t, r, want) | ||
| } | ||
|
|
||
| func TestReactions_marshall(t *testing.T) { |
|
@gmlewis Thanks for pointing these out. I made the requested changes. |
gmlewis
approved these changes
Oct 29, 2019
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to (#55) and adds a test for the Reaction and Reactions resources.