Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RenameBranch support #2119

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Conversation

vlsokol
Copy link
Contributor

@vlsokol vlsokol commented Oct 6, 2021

@google-cla
Copy link

google-cla bot commented Oct 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 6, 2021
@vlsokol
Copy link
Contributor Author

vlsokol commented Oct 6, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #2119 (c9e1ab6) into master (f664094) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2119   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         112      112           
  Lines        9956     9969   +13     
=======================================
+ Hits         9735     9748   +13     
  Misses        154      154           
  Partials       67       67           
Impacted Files Coverage Δ
github/repos.go 98.67% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f664094...c9e1ab6. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vlsokol !
Let me know what you think about simplifying the API endpoint:

github/repos.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @vlsokol ... thank you!
LGTM.

Awaiting second LGTM (from any repo contributor) before merging.

@gmlewis gmlewis changed the title feat: add rename-a-branch support Add RenameBranch support Nov 4, 2021
@gmlewis
Copy link
Collaborator

gmlewis commented Nov 4, 2021

Thank you, @AGMETEOR !
Merging.

@gmlewis gmlewis merged commit 0511421 into google:master Nov 4, 2021
@vlsokol vlsokol deleted the feature/rename-a-branch branch November 4, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "Rename a branch"
3 participants