Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages): fix specified user packages api path #2129

Merged
merged 1 commit into from
Oct 19, 2021
Merged

fix(packages): fix specified user packages api path #2129

merged 1 commit into from
Oct 19, 2021

Conversation

ysicing
Copy link
Contributor

@ysicing ysicing commented Oct 19, 2021

fix specified user packages api path

Error in getting specific user repository API path, should be /users/%v/packages, not /user/%v/packages

https://docs.github.com/en/rest/reference/packages#get-a-package-version-for-a-user

Signed-off-by: ysicing [email protected]

fix specified user packages api path

Signed-off-by: ysicing <[email protected]>
@google-cla
Copy link

google-cla bot commented Oct 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 19, 2021
@ysicing
Copy link
Contributor Author

ysicing commented Oct 19, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #2129 (b6ffeff) into master (72ec8bb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2129   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         112      112           
  Lines        9970     9970           
=======================================
  Hits         9749     9749           
  Misses        154      154           
  Partials       67       67           
Impacted Files Coverage Δ
github/users_packages.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72ec8bb...b6ffeff. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ysicing !
LGTM.
Merging.

@gmlewis gmlewis merged commit eb6fd34 into google:master Oct 19, 2021
@ysicing ysicing deleted the fix-user-packages-api branch October 19, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants