-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for External Groups #2217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @kabesan !
Just a few tweaks, please, then we should be ready for a second LGTM before merging.
Also, please make sure to run unit tests before pushing (not force-pushing) your upcoming changes. |
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
@gmlewis Thank your review. |
Codecov Report
@@ Coverage Diff @@
## master #2217 +/- ##
==========================================
+ Coverage 97.79% 97.82% +0.02%
==========================================
Files 112 112
Lines 10036 10166 +130
==========================================
+ Hits 9815 9945 +130
Misses 154 154
Partials 67 67
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @kabesan !
LGTM.
Awaiting second LGTM before merging.
(Please note that ALL other contributors to this repo are welcome to provide the second PR review/comment/approval that we need for merging and that we are not waiting for any particular reviewer unless otherwise noted.)
Fixed for diff coverage! |
@gmlewis Hi |
I am no longer able to add other reviewers, but any other contributor to this repo is welcome to review. |
Hi @pierce-m |
Thank you, @pierce-m ! |
Fixes: #2213 .
https://docs.github.com/en/enterprise-cloud@latest/rest/reference/teams#external-groups