-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding examples for app auth #2240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @patalwell !
Just a few minor tweaks, please.
@gmlewis good to go! |
I'm not seeing any changes since my last review... did you push them? Also, did you run
|
Codecov Report
@@ Coverage Diff @@
## master #2240 +/- ##
=======================================
Coverage 97.80% 97.80%
=======================================
Files 113 113
Lines 10205 10205
=======================================
Hits 9981 9981
Misses 156 156
Partials 68 68 Continue to review full report at Codecov.
|
@gmlewis oops, wrong branch. Pushed to the right one this time. Made the logging changes. I didn't want to run mod tidy since we ran into issues last time with the go.mod file and go.sum files, BUT ran the commands at your discretion :) Ran a test as well, I originally never ran one since I didn't have a test file. Also ran a linter! there was an error with one of the imports, so ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @patalwell !
LGTM.
Awaiting second LGTM from any other contributor to this repo before merging.
@wesleimp mind taking a look at these changes? |
Happy New Year! @gmlewis Hey so dont want to lose any momentum here, anyway we can ping another commiter for review? |
Happy New Year to you too, @patalwell ! Maybe @Parker77 has time to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you, @Parker77 ! |
@gmlewis opened a seperate PR from master, have a headache from trying to revert fetches I had pulled. I'd have to cherry pick commits and would rather start fresh.
To recap, this is a simple change to README.md and an example for GitHub app authentication flow so folks can understand how to leverage installations and access tokens.