Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for CreateWorkflowDispatchEventRequest.Ref #2263

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

kylekurz
Copy link
Contributor

go-github documentation on GitHub Actions Workflow parameters indicated
support for branch, tag or SHA, while the official docs indicated only
branch and tag are supported (which was verified by attempting to pass a
SHA to the workflow and seeing it ignored). This small changeset simply
aligns the documentation.

go-github documentation on GitHub Actions Workflow parameters indicated
support for branch, tag or SHA, while the official docs indicated only
branch and tag are supported (which was verified by attempting to pass a
SHA to the workflow and seeing it ignored). This small changeset simply
aligns the documentation.
@kylekurz
Copy link
Contributor Author

Fixes #2262

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kylekurz !
LGTM.
Merging.

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #2263 (b144c9d) into master (178169f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2263   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         114      114           
  Lines       10266    10266           
=======================================
  Hits        10042    10042           
  Misses        156      156           
  Partials       68       68           
Impacted Files Coverage Δ
github/actions_workflows.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178169f...b144c9d. Read the comment docs.

@gmlewis gmlewis changed the title 2262 - Documentation Mismatch Update docs for CreateWorkflowDispatchEventRequest.Ref Jan 21, 2022
@gmlewis gmlewis merged commit d4c1caf into google:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants