Add checks field to RequiredStatusChecks #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2276 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 114 114
Lines 10266 10266
=======================================
Hits 10042 10042
Misses 156 156
Partials 68 68
Continue to review full report at Codecov.
|
gmlewis
requested changes
Jan 29, 2022
|
It looks like the linter has a couple issues as well. |
in RequiredStatusChecksRequest
gmlewis
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to solve #2274.
From my own experimentation, I discovered that there's two ways that this
Checksfield can be used to update the required status checks for a protected branch:ProtectionRequest->RequiredStatusChecks->RequiredStatusCheckstruct, in this API call we must provide either one ofChecksorContexts(the other must benil) inRequiredStatusChecksto successfully update a branch protection. If you provide both or neither, you will get anInvalid Requesterror.RequiredStatusChecksRequest->RequiredStatusCheckstruct, in this API callChecksandContextsare both optional fields, if you provide both of them onlyCheckswill be used to update the status checks.