Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIMeta fields related to SSH keys #2293

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Feb 17, 2022

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 17, 2022

Thank you, @twpayne ! Please run go generate ./... and push the changes to the PR.
See CONTRIBUTING.md for more information.

@twpayne
Copy link
Contributor Author

twpayne commented Feb 17, 2022

🙈 Doh! Sorry about missing that. In updating this I also deliberately made the faux pas of modifying the original commit with a forced push, but I hope it's OK in this case as the extra changes are automatically generated.

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #2293 (2ec5da9) into master (2981e4f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2293   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files         115      115           
  Lines       10378    10378           
=======================================
  Hits        10154    10154           
  Misses        156      156           
  Partials       68       68           
Impacted Files Coverage Δ
github/misc.go 96.36% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2981e4f...2ec5da9. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @twpayne !
LGTM.
Merging.

@gmlewis gmlewis merged commit 62eaf97 into google:master Feb 17, 2022
@twpayne twpayne deleted the api-meta-ssh-keys branch February 17, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants