-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add security-advisory and code-scanning-alert event types #2311
Add security-advisory and code-scanning-alert event types #2311
Conversation
… added Signed-off-by: Sourik Ghosh <[email protected]>
ping reviewer |
Codecov Report
@@ Coverage Diff @@
## master #2311 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 115 115
Lines 10403 10415 +12
=======================================
+ Hits 10179 10191 +12
Misses 156 156
Partials 68 68
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @sourikghosh !
Just a few minor changes, please, then we will need a second LGTM from any other contributor to this repo before merging.
Signed-off-by: Sourik Ghosh <[email protected]>
Signed-off-by: Sourik Ghosh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, @sourikghosh !
Just a couple minor tweaks, please, then we should be ready for another LGTM and merging.
Signed-off-by: Sourik Ghosh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @sourikghosh !
LGTM.
Awaiting second LGTM from any other contributor to this repo before merging.
could any of you please review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to have the link to the github docs in the comment.
Besides that, LGTM
Co-authored-by: Simon Schneider <[email protected]>
Thank you, @raynigon ! |
Signed-off-by: Sourik Ghosh [email protected]
fixes #2306
What does this PR do ?
security-advisory event type with unit test added
code-scanning-alert event type with unit test added