Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URLs #2373

Merged
merged 12 commits into from
May 24, 2022
Merged

Update URLs #2373

merged 12 commits into from
May 24, 2022

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented May 24, 2022

Fixes: #2360.

Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #2373 (3e5a836) into master (6931fad) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2373   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         119      119           
  Lines       10545    10545           
=======================================
  Hits        10341    10341           
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/actions_artifacts.go 100.00% <ø> (ø)
github/actions_runner_groups.go 100.00% <ø> (ø)
github/actions_runners.go 100.00% <ø> (ø)
github/actions_secrets.go 100.00% <ø> (ø)
github/actions_workflow_jobs.go 100.00% <ø> (ø)
github/actions_workflow_runs.go 100.00% <ø> (ø)
github/actions_workflows.go 100.00% <ø> (ø)
github/activity.go 100.00% <ø> (ø)
github/activity_events.go 97.81% <ø> (ø)
github/activity_notifications.go 97.14% <ø> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6931fad...3e5a836. Read the comment docs.

Signed-off-by: Glenn Lewis <[email protected]>
@gmlewis
Copy link
Collaborator Author

gmlewis commented May 24, 2022

@Jille - could you please LGTM+Approve this when you get a chance?

I don't expect you to check every URL... but if you could please scan for any inconsistencies or irregularities and maybe spot-check some of the URLs that you are familiar with, that would be wonderfull.

Thank you, and I apologize for the broken links. It is extremely challenging to keep up with all the GitHub v3 API docs website overhauls and reorganizations.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label May 24, 2022
@Jille
Copy link
Contributor

Jille commented May 24, 2022

Thanks for doing this @gmlewis :) I understand it's not your fault and it seems like quite a burden to keep them in sync!

/lgtm

github/admin.go Outdated Show resolved Hide resolved
github/admin.go Outdated Show resolved Hide resolved
github/authorizations.go Outdated Show resolved Hide resolved
Signed-off-by: Glenn Lewis <[email protected]>
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label May 24, 2022
@gmlewis gmlewis merged commit 7a7a7f0 into google:master May 24, 2022
@gmlewis gmlewis deleted the i2630-update-urls branch May 24, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation links have changed
2 participants