Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing common event fields. #2384

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Conversation

wlynch
Copy link
Contributor

@wlynch wlynch commented Jun 15, 2022

See
https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#webhook-payload-object-common-properties
for the list of common fields.

I may have missed some - but gives better coverage for fields we were
missing before.

Signed-off-by: Billy Lynch [email protected]

@wlynch wlynch mentioned this pull request Jun 15, 2022
See
https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#webhook-payload-object-common-properties
for the list of common fields.

I may have missed some - but gives better coverage for fields we were
missing before.

Signed-off-by: Billy Lynch <[email protected]>
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #2384 (d045eda) into master (3072c0a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2384   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         119      119           
  Lines       10545    10545           
=======================================
  Hits        10341    10341           
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3072c0a...d045eda. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @wlynch !
LGTM.
Merging.

@gmlewis gmlewis merged commit 74c4599 into google:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants