-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PagesSource as struct for update pages API #2407
Conversation
Thank you, @gesellix - please run tests locally and make sure they pass. See CONTRIBUTING.md for more information. |
Sorry, my bad - I had read the CONTRIBUTION.md, but ignored them. Obivously 😓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @gesellix ! There's no need to squash commits, because we always do that upon merge in this repo... thank you, though.
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Codecov Report
@@ Coverage Diff @@
## master #2407 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 119 119
Lines 10546 10546
=======================================
Hits 10342 10342
Misses 140 140
Partials 64 64
Continue to review full report at Codecov.
|
@gmlewis do I have to find someone to review and put another LGTM on this PR? I'm not sure how we can progress on this one. This isn't meant to put any pressure on you or the other maintainers, though :) |
@gesellix - We rely on contributors of this repo to help review the outstanding PRs... feel free to review other open PRs if you have time. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you, @Parker77! We appreciate it. |
Closes #2406