Add 'pending_deployments' endpoint support (#2421) #2422
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
CLA signed. |
Codecov Report
@@ Coverage Diff @@
## master #2422 +/- ##
=======================================
Coverage 98.06% 98.07%
=======================================
Files 120 120
Lines 10558 10571 +13
=======================================
+ Hits 10354 10367 +13
Misses 140 140
Partials 64 64
Help us with your feedback. Take ten seconds to tell us how you rate us. |
github/actions_workflow_runs.go
Outdated
| type PendingDeploymentsRequest struct { | ||
| EnvironmentIDs []int64 `json:"environment_ids"` | ||
| State *string `json:"state"` | ||
| Comment *string `json:"comment"` |
There was a problem hiding this comment.
Since these two last fields are required, let's please change them to string (instead of *string).
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
|
@gmlewis PTAL |
There was a problem hiding this comment.
Thank you, @DavidGamba !
LGTM.
Awaiting second LGTM from any other contributor to this repo before merging.
|
Thank you, @raynigon ! |
No description provided.