Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LFS control #2429

Merged
merged 6 commits into from
Aug 13, 2022
Merged

Add LFS control #2429

merged 6 commits into from
Aug 13, 2022

Conversation

dsm-kb
Copy link
Contributor

@dsm-kb dsm-kb commented Aug 2, 2022

Add ability to turn LFS on / off for repo

@google-cla
Copy link

google-cla bot commented Aug 2, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dsm-kb dsm-kb closed this Aug 2, 2022
@dsm-kb dsm-kb reopened this Aug 2, 2022
@dsm-kb dsm-kb closed this Aug 2, 2022
@dsm-kb dsm-kb reopened this Aug 2, 2022
@dsm-kb dsm-kb closed this Aug 2, 2022
@dsm-kb dsm-kb reopened this Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #2429 (df9431b) into master (3a432d6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2429   +/-   ##
=======================================
  Coverage   98.06%   98.07%           
=======================================
  Files         120      121    +1     
  Lines       10558    10582   +24     
=======================================
+ Hits        10354    10378   +24     
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/repos_lfs.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dsm-kb dsm-kb marked this pull request as ready for review August 2, 2022 21:48
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dsm-kb !
Just a few minor tweaks, please, then we should be ready for a second LGTM before merging.

github/repos_lfs.go Outdated Show resolved Hide resolved
github/repos_lfs_test.go Outdated Show resolved Hide resolved
github/repos_lfs.go Outdated Show resolved Hide resolved
github/repos_lfs.go Outdated Show resolved Hide resolved
github/repos_lfs.go Outdated Show resolved Hide resolved
github/repos_lfs.go Outdated Show resolved Hide resolved
github/repos_lfs_test.go Outdated Show resolved Hide resolved
github/repos_lfs_test.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 2, 2022
@dsm-kb dsm-kb requested a review from gmlewis August 3, 2022 01:22
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed a couple minor nits.

github/repos_lfs.go Outdated Show resolved Hide resolved
github/repos_lfs.go Outdated Show resolved Hide resolved
@dsm-kb dsm-kb requested a review from gmlewis August 3, 2022 01:51
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dsm-kb !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@dsm-kb
Copy link
Contributor Author

dsm-kb commented Aug 3, 2022

Thank you @gmlewis for the LGTM :-)

@dsm-kb dsm-kb mentioned this pull request Aug 4, 2022
Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsm-kb For ypur next PR it would be nice, if you could explain in one or two sentences what you want to do in the PR description. Makes the review a bit easier :)

@gmlewis gmlewis merged commit 7a7c657 into google:master Aug 13, 2022
@gmlewis
Copy link
Collaborator

gmlewis commented Aug 13, 2022

Thank you, @raynigon !
Merged.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants