-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LFS control #2429
Add LFS control #2429
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2429 +/- ##
=======================================
Coverage 98.06% 98.07%
=======================================
Files 120 121 +1
Lines 10558 10582 +24
=======================================
+ Hits 10354 10378 +24
Misses 140 140
Partials 64 64
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @dsm-kb !
Just a few minor tweaks, please, then we should be ready for a second LGTM before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed a couple minor nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @dsm-kb !
LGTM.
Awaiting second LGTM from any other contributor to this repo before merging.
Thank you @gmlewis for the LGTM :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dsm-kb For ypur next PR it would be nice, if you could explain in one or two sentences what you want to do in the PR description. Makes the review a bit easier :)
Thank you, @raynigon ! |
Add ability to turn LFS on / off for repo