Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: adding api and web to meta api endpoint. #2435

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

Jamian
Copy link
Contributor

@Jamian Jamian commented Aug 17, 2022

The Api and Web lists are returned from the meta API but still aren't supported in the Go library. This change exposes them in the same way as the other blocks which are returned. I'm working on a change in the GitHub Terraform provider to also support exposing these API/Web CIDRs so if this is all ok I can continue on with that change as well.

@google-cla
Copy link

google-cla bot commented Aug 17, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Jamian !
Just a couple minor tweaks, please, in addition to the CLA.

github/misc.go Outdated Show resolved Hide resolved
github/misc.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #2435 (05d67f4) into master (acca0b6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2435   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         122      122           
  Lines       10632    10632           
=======================================
  Hits        10428    10428           
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/misc.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Jamian
Copy link
Contributor Author

Jamian commented Aug 17, 2022

@gmlewis Hey, thanks for the feedback. I have made the changes and sorted the CLA out. 👍

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 17, 2022

Thanks, @Jamian ! I think the tests might need updating, please.

@Jamian
Copy link
Contributor Author

Jamian commented Aug 18, 2022

Hey @gmlewis, of course - awkwardly embarrassing! Just pushed the fixes to get tests passing 🤞

@Jamian Jamian requested a review from gmlewis August 18, 2022 11:58
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Jamian !
LGTM.
Merging.

@gmlewis gmlewis merged commit 903be14 into google:master Aug 18, 2022
@Jamian Jamian deleted the feature/misc_meta_api_and_web branch August 18, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants