Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GenerateReleaseNotes from RepositoriesService.EditRelease #2445

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Remove GenerateReleaseNotes from RepositoriesService.EditRelease #2445

merged 1 commit into from
Sep 5, 2022

Conversation

coro
Copy link
Contributor

@coro coro commented Aug 24, 2022

This PR closes #2444

According to the GitHub v3 API reference,
generate_release_notes is not a recognised body parameter of the endpoint to update a release. If provided to
the API, it will have no effect.

This commit removes the setting of this parameter when updating a release, to avoid confusion in the effect of
setting this parameter.

According to the [GitHub v3 API reference](https://docs.github.com/en/rest/releases/releases#update-a-release),
`generate_release_notes` is not a recognised body parameter of the endpoint to update a release. If provided to
the API, it will have no effect.

This commit removes the setting of this parameter when updating a release, to avoid confusion in the effect of
setting this parameter.
@google-cla
Copy link

google-cla bot commented Aug 24, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #2445 (4bd098b) into master (243bda8) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2445      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         122      122              
  Lines       10690    10689       -1     
==========================================
- Hits        10480    10479       -1     
  Misses        144      144              
  Partials       66       66              
Impacted Files Coverage Δ
github/repos_releases.go 89.36% <ø> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @coro !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 24, 2022
Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 5, 2022
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 5, 2022

Thank you, @raynigon !
Merging.

@gmlewis gmlewis merged commit e8cac35 into google:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenerateReleaseNotes will have no effect in RepositoriesService.EditRelease
3 participants