Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'whitelist' to 'allowlist' in oauth class selectors #2488

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Rename 'whitelist' to 'allowlist' in oauth class selectors #2488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scrape/apps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func (c *Client) AppRestrictionsEnabled(org string) (bool, error) {
return false, err
}

s := doc.Find(".oauth-application-whitelist svg").First()
s := doc.Find(".oauth-application-allowlist svg").First()
if s.Length() == 0 {
return false, errors.New("unable to find expected markup")
}
Expand All @@ -52,7 +52,7 @@ func (c *Client) ListOAuthApps(org string) ([]OAuthApp, error) {
}

var apps []OAuthApp
doc.Find(".oauth-application-whitelist ul > li").Each(func(i int, s *goquery.Selection) {
doc.Find(".oauth-application-allowlist ul > li").Each(func(i int, s *goquery.Selection) {
var app OAuthApp
app.Name = s.Find(".request-info strong").First().Text()
app.Description = s.Find(".request-info .application-description").Text()
Expand Down
2 changes: 1 addition & 1 deletion scrape/testdata/access-restrictions-disabled.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<div class="col-9">

<div class="boxed-group oauth-application-whitelist ">
<div class="boxed-group oauth-application-allowlist ">
<h3>Third-party application access policy</h3>
<div class="boxed-group-inner">
<p>
Expand Down
2 changes: 1 addition & 1 deletion scrape/testdata/access-restrictions-enabled.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

<div class="col-9">

<div class="boxed-group oauth-application-whitelist is-selectable">
<div class="boxed-group oauth-application-allowlist is-selectable">
<h3>Third-party application access policy</h3>
<div class="boxed-group-inner">
<p>
Expand Down