-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases for JSON resource marshaling #2524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @sayalideshmukh10 .
We might as well make the formatting of the wanted JSON consistent and easy-to-read, as if it were created by a JSON indented marshaler.
Codecov Report
@@ Coverage Diff @@
## master #2524 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 123 123
Lines 10813 10813
=======================================
Hits 10594 10594
Misses 150 150
Partials 69 69 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hello @gmlewis, I am a first-time contributor to Hackoctober, It will be a great help if you can accept my contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @sayalideshmukh10 !
Before we merge, would you like to resolve the conflicts with the recent merges to the master branch, or would you like me to do it?
…into test_case_scim
Thank you @gmlewis for asking about merging conflicts and resolving |
Added test cases for the below structs - github/scim.go (file)
Helps: #55.