Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support workflow restrictions in actions_runner_groups #2559

Merged

Conversation

bob-bins
Copy link
Contributor

@bob-bins bob-bins commented Nov 7, 2022

Fixes: #2558.

@google-cla
Copy link

google-cla bot commented Nov 7, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title #2558 support workflow restrictions in actions_runner_groups Support workflow restrictions in actions_runner_groups Nov 7, 2022
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bob-bins .
Please run "go generate ./..." and push the changes to the PR (we squash-and-merge all PRs) as described in CONTRIBUTING.md, and make sure to sign the CLA before we proceed.

@bob-bins bob-bins force-pushed the github-runners-workflow-restrictions branch from f2daa05 to 7cbe67b Compare November 8, 2022 01:10
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #2559 (1f3d44e) into master (9598613) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2559   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files         124      125    +1     
  Lines       10842    10875   +33     
=======================================
+ Hits        10623    10656   +33     
  Misses        150      150           
  Partials       69       69           
Impacted Files Coverage Δ
github/actions_runner_groups.go 100.00% <ø> (ø)
github/github.go 97.37% <ø> (ø)
github/dependabot_alerts.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bob-bins bob-bins force-pushed the github-runners-workflow-restrictions branch 2 times, most recently from 074a8a8 to 0461a6c Compare November 8, 2022 01:14
@bob-bins bob-bins force-pushed the github-runners-workflow-restrictions branch from 0461a6c to 9d60210 Compare November 8, 2022 01:16
@bob-bins
Copy link
Contributor Author

bob-bins commented Nov 8, 2022

@gmlewis I know the Contributors readme discourages force pushing, but I squashed and force-pushed when I corrected my commit signature. Thank you!

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bob-bins !
Please make sure to run gofmt on the this file and its test file, and push the results after making the tweaks below.

github/actions_runner_groups.go Outdated Show resolved Hide resolved
github/actions_runner_groups.go Outdated Show resolved Hide resolved
@bob-bins bob-bins force-pushed the github-runners-workflow-restrictions branch from e13492e to d184448 Compare November 8, 2022 04:15
@bob-bins bob-bins requested a review from gmlewis November 8, 2022 04:16
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bob-bins !
LGTM.
Merging.

@gmlewis gmlewis merged commit db32fc6 into google:master Nov 9, 2022
@bob-bins bob-bins deleted the github-runners-workflow-restrictions branch November 10, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support workflow restrictions in actions_runner_groups
2 participants