-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the 'require_last_push_approval' field #2567
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @noamd-legit !
Could you please also add this field (but as a *bool
) to the PullRequestReviewsEnforcementUpdate
struct?
Codecov Report
@@ Coverage Diff @@
## master #2567 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 125 125
Lines 10875 10875
=======================================
Hits 10656 10656
Misses 150 150
Partials 69 69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@gmlewis Added :) |
Co-authored-by: Glenn Lewis <[email protected]>
You will probably also need to run |
|
Did you literally type |
Yeah, but apparently I ran the command on a different branch locally 😐 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @noamd-legit !
LGTM.
Merging.
No description provided.