Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add httpcache code example to README.md #2632

Merged
merged 5 commits into from
Jan 18, 2023
Merged

Conversation

madneal
Copy link
Contributor

@madneal madneal commented Jan 18, 2023

Relates to: #2631.

@google-cla
Copy link

google-cla bot commented Jan 18, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @madneal !
Just a couple minor tweaks, please.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@gmlewis gmlewis changed the title add httpcache code sample refer to #2631 Add httpcache code example to README.md Jan 18, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #2632 (e8019a0) into master (34cc7b4) will not change coverage.
The diff coverage is n/a.

❗ Current head e8019a0 differs from pull request most recent head f5c4d07. Consider uploading reports for the commit f5c4d07 to get more accurate results

@@           Coverage Diff           @@
##           master    #2632   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         130      130           
  Lines       11144    11144           
=======================================
  Hits        10925    10925           
  Misses        150      150           
  Partials       69       69           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @madneal !
LGTM.
Merging.

@gmlewis gmlewis merged commit ab8b241 into google:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants