Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all fields from time.Time to github.Timestamp #2646

Merged
merged 4 commits into from
Jan 26, 2023
Merged

Change all fields from time.Time to github.Timestamp #2646

merged 4 commits into from
Jan 26, 2023

Commits on Jan 26, 2023

  1. Fix test to conform to the changes in time related fields

    @zombieleet
    zombieleet committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    d90ea32 View commit details
    Browse the repository at this point in the history

  2. Change time related fields from *time.Time to *Timestamp

    @zombieleet
    zombieleet committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    ea39e12 View commit details
    Browse the repository at this point in the history

  3. exclude composites from lint checks. 

    Composites checks prevents using unkeyed fields, which is not needed in the examples project because
`time.Time` is embedded into `github.Timestamp`
    @zombieleet
    zombieleet committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    5ae8401 View commit details
    Browse the repository at this point in the history

  4. Fix examples project to use github.Timestamp

    @zombieleet
    zombieleet committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    d65736f View commit details
    Browse the repository at this point in the history