Fix parse token expiration #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlewis
requested changes
Jan 30, 2023
There was a problem hiding this comment.
Thank you, @jerolimov !
Just a few minor tweaks, please, then we should be ready for a second LGTM+Approval before merging.
gmlewis
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2650 +/- ##
=======================================
Coverage 98.07% 98.08%
=======================================
Files 130 130
Lines 11302 11304 +2
=======================================
+ Hits 11085 11087 +2
Misses 148 148
Partials 69 69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
nice one, thanks |
christoph-jerolimov
force-pushed
the
fix-parse-token-expiration
branch
from
4fd3a6c
to
b3543f7
Compare
|
@gmlewis thanks for the feedback, updated the PR. I took everything. 👍 |
christoph-jerolimov
force-pushed
the
fix-parse-token-expiration
branch
from
b3543f7
to
9bac7a5
Compare
gmlewis
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Thank you, @jerolimov !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
Thank you, @valbeat ! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2649 issue without breaking API changes.
If you prefer I could also make it optional (
TokenExpiration *Timestamp) so that it's not required to check for "is timestamp equals 0001-01-01)Or by adding a new
type TokenExpiration time.Timewith afunc IsValidfor a token that has no expiration header?!But both would change the public API and for my first PR here I focused on fixing just the bug without an API change.