-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for actions variables #2652
Conversation
Signed-off-by: Federico Di Pierro <[email protected]>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @FedeDP!
It looks great and with a few minor tweaks we should be ready for a second LGTM+Approval before merging.
Codecov Report
@@ Coverage Diff @@
## master #2652 +/- ##
==========================================
+ Coverage 98.08% 98.10% +0.02%
==========================================
Files 130 131 +1
Lines 11304 11442 +138
==========================================
+ Hits 11087 11225 +138
Misses 148 148
Partials 69 69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Glenn Lewis <[email protected]>
… and `ActionVariables`. Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
Should've fixed everything ;) Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @FedeDP !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I merged master into this branch. |
Thank you, @valbeat ! |
https://docs.github.com/en/rest/actions/variables
Fixes #2624
actions_variables.go
actions_variables_test.go