Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission filter for list collaborators #2653

Merged
merged 5 commits into from
Feb 2, 2023

Conversation

Sairaviteja27
Copy link
Contributor

@Sairaviteja27 Sairaviteja27 commented Feb 1, 2023

Fixes #2651

Copy link

@MytsYurii MytsYurii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@gmlewis gmlewis changed the title add permission filter for list collaborators Add permission filter for list collaborators Feb 1, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Sairaviteja27 !
Just a couple tiny tweaks, please.

github/repos_collaborators.go Outdated Show resolved Hide resolved
github/repos_collaborators.go Outdated Show resolved Hide resolved
@Sairaviteja27 Sairaviteja27 marked this pull request as ready for review February 2, 2023 11:20
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Sairaviteja27 !
LGTM.
Merging.

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #2653 (f4de40c) into master (72dd8ad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2653   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files         131      131           
  Lines       11442    11442           
=======================================
  Hits        11225    11225           
  Misses        148      148           
  Partials       69       69           
Impacted Files Coverage Δ
github/repos_collaborators.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis gmlewis merged commit b2fef5d into google:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Permission filter to collaborators list
3 participants