Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Create/Update methods to return the workflow #2759

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

avivek
Copy link
Contributor

@avivek avivek commented Apr 14, 2023

Updated create and update org required workflow methods to return the required workflow object returned by the github api.
Merging this Fixes #2756

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #2759 (79e6066) into master (6d92e30) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2759   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         132      132           
  Lines       11628    11638   +10     
=======================================
+ Hits        11402    11412   +10     
  Misses        154      154           
  Partials       72       72           
Impacted Files Coverage Δ
github/actions_required_workflows.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Apr 14, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @avivek !
Just a few minor tweaks, please.
Then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/actions_required_workflows.go Show resolved Hide resolved
github/actions_required_workflows.go Show resolved Hide resolved
github/actions_required_workflows.go Show resolved Hide resolved
github/actions_required_workflows.go Show resolved Hide resolved
@avivek
Copy link
Contributor Author

avivek commented Apr 15, 2023

Thanks for your quick review @gmlewis .
I have made the changes, please take a look now.

@avivek avivek requested a review from gmlewis April 15, 2023 12:40
@gmlewis gmlewis changed the title Updated Create/Update methods to return the workflow Update Create/Update methods to return the workflow Apr 15, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @avivek !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 17, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Apr 17, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit ff89f86 into google:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Org Required workflow create and update api's should return the workflow object
3 participants