-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support x-ratelimit-reset handling for secondary rate limits #2775
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2775 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 132 132
Lines 11638 11648 +10
=======================================
+ Hits 11412 11422 +10
Misses 154 154
Partials 72 72
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @gofri !
LGTM.
Awaiting CLA and second LGTM+Approval from any other contributor to this repo before merging.
Thank you, @valbeat ! |
GitHub API states that x-ratelimit-reset might be returned instead of the Retry-After header for secondary rate limits.
Seems like GitHub recently started using it. Some evidence:
This PR handles this case as a fallback for Retry-After, and cleans the code a bit while at it