Add missing fields to AuditEntry #2786
Conversation
gmlewis
changed the title
There was a problem hiding this comment.
Thank you, @patriknordlen!
Just a few tweaks, please, then we will be ready to merge.
| @@ -29,69 +29,96 @@ type HookConfig struct { | |||
| Secret *string `json:"secret,omitempty"` | |||
| } | |||
|
|
|||
| type ActorLocation struct { | |||
There was a problem hiding this comment.
Please add godoc-style comments to each new exported struct.
Co-authored-by: Glenn Lewis <[email protected]>
|
Please make sure to run |
|
Resolving type-related issues in tests now. |
|
Almost there... please update your unit tests so that "go test ./..." passes on your local system, then push the changes. |
Codecov Report
@@ Coverage Diff @@
## master #2786 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 132 132
Lines 11650 11650
=======================================
Hits 11424 11424
Misses 154 154
Partials 72 72
|
There was a problem hiding this comment.
Thank you, @patriknordlen !
LGTM.
Merging after tests pass.
Fixes: #2785.
Adds the following fields to the
AuditEntrystruct and populates them when they exist in a response from the API:ActorIP- IP of actor (if enabled in GitHub audit logs)ActorLocation- location of actor (country code etc)HashedToken- hashed token identifier when an action is performed using an access tokenJobWorkflowRef- reference to workflow job when a workflow runsOAuthApplicationID- OAuth application identifier when an OAuth application performs an actionOrgID- organization numeric IDProgrammaticAccessType- type of programmatic access (i.e. via token, cli, oauth app...)PullRequestID- self-explanatoryPullRequestTitle- self-explanatoryPullRequestURL- self-explanatoryReasons- Used when a user overrides branch protection, includes info on user's stated reason whyRunNumber- the numerical ID of the workflow runTokenID- token ID when an action is performed using an access tokenTokenScopes- string containing scopes assigned to a tokenTopic- topic used in workflow runsUserAgent- user-agent used in performing an action