-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generate-jitconfig API for self-hosted runners #2801
Add generate-jitconfig API for self-hosted runners #2801
Conversation
Signed-off-by: Magnus Kulke <[email protected]>
Signed-off-by: Magnus Kulke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mkulke.
Please remember to run |
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Signed-off-by: Magnus Kulke <[email protected]>
Hi @mkulke ! I know the docs don't mention enterprises (although the blog seems to). I would be surprised if this was missing for I think I can ask someone to test this out. But I think that can be added as a separate PR. I don't want to block this one 😄. |
Signed-off-by: Magnus Kulke <[email protected]>
Signed-off-by: Magnus Kulke <[email protected]>
yeah, I was also wondering about that and opted to limit it to what's documented atm. |
Thanks for adding this! |
Signed-off-by: Magnus Kulke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mkulke !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Codecov Report
@@ Coverage Diff @@
## master #2801 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 132 132
Lines 11650 11676 +26
=======================================
+ Hits 11424 11450 +26
Misses 154 154
Partials 72 72
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you, @valbeat ! |
GitHub recently introduced just-in-time configuration for self-hosted runner, so runners do not need to be seeded with privileged tokens. This PR adds those endpoints for orgs + repos.