-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of codespaces API #2803
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed-off-by: Aidan Jensen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, @artificial-aidan!
Just a few changes please, and then we will be ready for a second LGTM+Approval before merging.
github/codespaces.go
Outdated
StorageInBytes *int `json:"storage_in_bytes,omitempty"` | ||
MemoryInBytes *int `json:"memory_in_bytes,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StorageInBytes *int `json:"storage_in_bytes,omitempty"` | |
MemoryInBytes *int `json:"memory_in_bytes,omitempty"` | |
StorageInBytes *int64 `json:"storage_in_bytes,omitempty"` | |
MemoryInBytes *int64 `json:"memory_in_bytes,omitempty"` |
I'll push those up. I also renamed some of the list methods to match others in the repo. |
Thank you! |
Working on the CLA now. Should I push the suggested changes, then run go generate? |
Signed-off-by: Aidan Jensen <[email protected]>
e569e7b
to
775679f
Compare
Signed-off-by: Aidan Jensen <[email protected]>
Signed-off-by: Aidan Jensen <[email protected]>
Signed-off-by: Aidan Jensen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2803 +/- ##
==========================================
- Coverage 98.06% 98.00% -0.06%
==========================================
Files 132 134 +2
Lines 11650 11915 +265
==========================================
+ Hits 11424 11677 +253
- Misses 154 162 +8
- Partials 72 76 +4
|
Signed-off-by: Aidan Jensen <[email protected]>
Signed-off-by: Aidan Jensen <[email protected]>
The last commit basically mirrors the functionality and layout of Action secrets, but consolidated the tests a bit. I added some examples I used when validating its functionality against a real github. |
Please don't use force-push in this repo, as we always squash-and-merge at the end anyway. |
Sorry about that. Must have been out of habit 👍 |
Signed-off-by: Aidan Jensen <[email protected]>
Signed-off-by: Aidan Jensen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @artificial-aidan !
LGTM.
Awaiting CLA and LGTM+Approval from any other contributor to this repo before merging.
It looks like you might need to run |
Signed-off-by: Aidan Jensen <[email protected]>
@gmlewis got the CLA signed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @artificial-aidan !
LGTM.
Awaiting LGTM+Approval from any other contributor to this repo before merging.
Thank you, @valbeat ! |
#2362