Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old_name field in AuditEntry #2849

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Fix old_name field in AuditEntry #2849

merged 7 commits into from
Jul 28, 2023

Conversation

lmartinking
Copy link
Contributor

Much to my chagrin, the audit log view in the site manager does not follow the shape of the API response.

I previously raised a PR #2843 which was merged yesterday. Unfortunately, it does not work with the payload returned from the API.

My sincere apologies about this.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #2849 (9f800d2) into master (c8c34d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2849   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         138      138           
  Lines       12318    12318           
=======================================
  Hits        12080    12080           
  Misses        162      162           
  Partials       76       76           
Files Changed Coverage Δ
github/orgs_audit_log.go 100.00% <ø> (ø)

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lmartinking !
Now worries. I'm glad you caught it before I cut the new release. 😄

github/orgs_audit_log.go Outdated Show resolved Hide resolved
github/orgs_audit_log.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). NeedsReview PR is awaiting a review before merging. labels Jul 28, 2023
@lmartinking
Copy link
Contributor Author

lmartinking commented Jul 28, 2023

@gmlewis I have one more field to add, which I will do in another PR

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jul 28, 2023
@lmartinking
Copy link
Contributor Author

@gmlewis do you want the structs to mirror the shape of the API or would you prefer it flattened? Which was why I had it as a composite member.

@lmartinking lmartinking requested a review from gmlewis July 28, 2023 14:17
@gmlewis
Copy link
Collaborator

gmlewis commented Jul 28, 2023

@gmlewis do you want the structs to mirror the shape of the API or would you prefer it flattened? Which was why I had it as a composite member.

We typically do not use composite members in this repo.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lmartinking !
LGTM.
Merging.

@gmlewis gmlewis changed the title [Fix] old_name field in AuditEntry is incorrectly mapped from the JSON returned by the Audit Log API Fix old_name field in AuditEntry Jul 28, 2023
@gmlewis gmlewis merged commit 44d09ce into google:master Jul 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants